fix(github): use different graphql path in enterprise version#7541
Conversation
dosubot
Bot
added
size:S
| endpoint.Path = "/graphql" // see https://docs.github.com/en/graphql/guides/forming-calls-with-graphql | ||
| if endpoint.Hostname() != "api.github.com" { | ||
| // see https://docs.github.com/en/enterprise-server@3.11/graphql/guides/forming-calls-with-graphql | ||
| endpoint.Path = "/api/graphql" |
There was a problem hiding this comment.
LGTM overall.
I just want to make sure that all On-premise GitHub deployments are Enterprise Edition? Or in other words, do they all follow this URL-forming pattern?
There was a problem hiding this comment.
Hey @klesh ,
Is the question directed to me or you mean you are checking it in the background?
From my side it is hard to know if all on-premise instances use this pattern as I only know the instance we use. Besides from that I double checked with Renovate source code and they also have custom handling for Github Enterprise, see https://github.com/renovatebot/renovate/blob/main/lib/util/github/graphql/datasource-fetcher.ts#L85.
So I would consider it safe to assume that this is the standard for on-premise instances.
There was a problem hiding this comment.
Thanks for the information, very informative.
3 participants
pr-type/bug-fix,pr-type/feature-development, etc.Summary
Does this close any open issues?
Other Information